Skip to content

Add QuadContourSet.remove. #24143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add QuadContourSet.remove. #24143

merged 1 commit into from
Oct 12, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 11, 2022

PR Summary

Closes #5332.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added this to the v3.7.0 milestone Oct 11, 2022
@timhoffm
Copy link
Member

timhoffm commented Oct 11, 2022 •
edited
Loading

Flake 8:

./lib/matplotlib/contour.py:589:13: F402 import 'text' from line 20 shadowed by loop variable

This is due to a top-level import matplotlib.text as text.

I think we should follow the relatively common internal convention to switch the import to mtext (or directly from matplotlib.text import Text).

@anntzer
Copy link
Contributor Author

anntzer commented Oct 11, 2022

Thanks, fixed.

@QuLogic QuLogic merged commit 6cc7cda into matplotlib:main Oct 12, 2022
@anntzer anntzer deleted the cr branch October 12, 2022 05:56
jacoverster pushed a commit to jacoverster/matplotlib that referenced this pull request Oct 17, 2022
@QuLogic @jvcsir
Merge pull request matplotlib#24143 from anntzer/cr
9641fff 
Add QuadContourSet.remove.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: contour
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

QuadContourSet lacks remove method
3 participants
@anntzer @timhoffm @QuLogic