Skip to content

[DOC]: add parent link for FuncAnimation and ArtistAnimation #24169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

[DOC]: add parent link for FuncAnimation and ArtistAnimation #24169

merged 2 commits into from
Oct 18, 2022

Conversation

kwsp
Copy link
Contributor

@kwsp kwsp commented Oct 14, 2022

PR Summary

#24150 (comment)

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes). No code changes
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@kwsp
Copy link
Contributor Author

kwsp commented Oct 14, 2022

I'm currently having trouble building matplotlib on my machine, and so I cannot build the docs that reflect the changes I made.

#24168

@kwsp kwsp marked this pull request as ready for review October 14, 2022 23:41
@oscargus
Copy link
Member

Closing and reopening to retrigger docs build. (PR looks OK, not sure what causes the CircleCI error. Happens sometimes.)

@oscargus oscargus closed this Oct 15, 2022
@oscargus oscargus reopened this Oct 15, 2022
Copy link
Member

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the doc build directly fails. Looks good though!

(I think the description is better than before, even if we provides inherited members.)

@story645 story645 added this to the v3.6.2 milestone Oct 16, 2022
@oscargus
Copy link
Member

I'll merge this as I do not understand what causes the completely failed doc-build...

Thanks @kwsp and congratulations on your first merged PR in Matplotlib! Hope to see your around!

@oscargus oscargus merged commit 007c4c1 into matplotlib:main Oct 18, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 18, 2022
@oscargus oscargus changed the title [DOC]: added parent link for FuncAnimation and ArtistAnimation [DOC]: add parent link for FuncAnimation and ArtistAnimation Oct 18, 2022
tacaswell added a commit that referenced this pull request Oct 18, 2022
…169-on-v3.6.x

Backport PR #24169 on branch v3.6.x ([DOC]: added parent link for `FuncAnimation` and `ArtistAnimation`)
@kwsp
Copy link
Contributor Author

kwsp commented Oct 18, 2022

@oscargus thanks!

@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants