Don't simplify paths used for autoscaling #24177
Merged
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path simplification is really scaled for pixel/display unit outputs, but paths in autoscaling are in data units. This sometimes causes autoscaling to pick the wrong limits, as the simplified paths may be smaller than the originals. Fixes matplotlib#24097
oscargus
approved these changes
Oct 15, 2022
anntzer
approved these changes
Oct 15, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 15, 2022
QuLogic
added a commit
that referenced
this pull request
Oct 17, 2022
…177-on-v3.6.x Backport PR #24177 on branch v3.6.x (Don't simplify paths used for autoscaling)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Path simplification is really scaled for pixel/display unit outputs, but paths in autoscaling are in data units. This sometimes causes autoscaling to pick the wrong limits, as the simplified paths may be smaller than the originals.
This uses a simplified copy of the bin paths from #24097, skipping the whole random generation and histogram step in favour hardcoding the array.
Fixes #24097
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).