MNT: Remove redundant method, fix signature and add doc-string to draw_tex
#24182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Oct 15, 2022
| @@ -693,9 +693,9 @@ def draw_image(self, gc, x, y, im, transform=None): | |||
| interp, w, h, fname_img)) | |||
| _writeln(self.fh, r"\end{pgfscope}") | |||
|
|
|||
| def draw_tex(self, gc, x, y, s, prop, angle, ismath="TeX", mtext=None): | |||
| def draw_tex(self, gc, x, y, s, prop, angle, *, mtext=None): | |||
There was a problem hiding this comment.
Can we do this without deprecation?
There was a problem hiding this comment.
Unclear. It is not used and was deprecated from all other draw_tex methods in #17484. However, it seems to have been forgotten for the pgf backend.
There was a problem hiding this comment.
The deprecations were removed in #19900 and while it was touched, it does not seem like anyone noticed that the signature was different.
timhoffm
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Doc-string is maybe not required as it is so close to
draw_text, but still...PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).