-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix pie chart in demo_agg_filter.py #24261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The implementation of See, for example, the double pendulum example which implements the code in python rather than using a scipy method which would provide better results. |
Good observation! (Should probably not approve stuff with a heavy cold...) It would be great to get rid of the scipy dependency. |
Would it be okay if the example uses "shrink=None" so that importing scipy is bypassed? |
Welcome back @leejjoon ! |
I think the effect you are looking for can be had with library-native changes to the Here is a quick example demonstrating the differences between the example as is (with your fixes so that it works, but without |
74c016d
to
118bfcc
Compare
Okay, I have removed shrink parameter so the scipy dependency. However, I still think that it would be good to have a I also have rebased the PR to the current main and force-pushed it. |
Thanks! |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…261-on-v3.6.x Backport PR #24261 on branch v3.6.x (Fix pie chart in demo_agg_filter.py)
* fix demo_agg_filter.py * Update examples/misc/demo_agg_filter.py Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
PR Summary
This fixes the pie chart in [demo_agg_filter.py] (https://matplotlib.org/stable/gallery/misc/demo_agg_filter.html) which is incorrectly displayed with simple black color . Fixed image is shown below. It also add new
shrink
parameter and a bit of more documentation.PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).