Skip to content

Minor improvements to Annotations Tutorial #24314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2022
Merged

Minor improvements to Annotations Tutorial #24314

merged 1 commit into from
Nov 1, 2022

Conversation

timhoffm
Copy link
Member

Follow up to #23606.

  • Move the basic text() vs. annotate() discussion to the top
  • Styling in "Annotating with boxed text": move the text from Axes edge to center; less glaring colors

There's still more that can be done in later PRs ...

@timhoffm timhoffm force-pushed the doc-annotation-tutorial branch from c19b99c to d69fc98 Compare October 30, 2022 23:32
story645
story645 reviewed Oct 30, 2022
View reviewed changes
@story645
Copy link
Member

Like the new position & actually having an intro better 😅

@timhoffm timhoffm force-pushed the doc-annotation-tutorial branch from d69fc98 to ba03e48 Compare November 1, 2022 12:03
@timhoffm
Copy link
Member Author

timhoffm commented Nov 1, 2022

@story645 @jklymak I've just taken over the suggestions. I'm not up to fine-tuning the semantics of "annotation" or whether or not text() is an option for simple annotations. Please do that in follow-up PRs, or speak up to take over this PR push further improvements.

@timhoffm timhoffm force-pushed the doc-annotation-tutorial branch from ba03e48 to 784297d Compare November 1, 2022 16:22
@timhoffm @story645
Minor improvements to Annotations Tutorial
484e380 
- Move the basic text() vs. annotate() discussion to the top
- Styling in "Annotating with boxed text": move the text from
  Axes edge to center; less glaring colors

Co-authored-by: hannah <story645@gmail.com>
@timhoffm timhoffm force-pushed the doc-annotation-tutorial branch from 784297d to 484e380 Compare November 1, 2022 20:53
@timhoffm
Copy link
Member Author

timhoffm commented Nov 1, 2022

I self-merge based on @story645's approval.

@timhoffm timhoffm added this to the v3.7.0 milestone Nov 1, 2022
@timhoffm timhoffm merged commit 77c33f0 into matplotlib:main Nov 1, 2022
@timhoffm timhoffm deleted the doc-annotation-tutorial branch November 1, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Documentation topic: annotation
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @story645 @jklymak @ksunden