Remove custom polar behaviour in LogLocator #24439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As part of investigating #24383, I noticed that
LogLocator
has custom behaviour for polar Axes. This dates back 13 years (!!) to 1fdd5a8. Since log-scaled polar Axes are broken anyway, I thought I would remove this logic and see if any existing tests break.I've also added a new test to check the y-ticks on a log-scaled polar plot. Prior to this PR the ticks were given at
[ 0.01 0.1 1. 10. ]
, not including the max limit of100
, showing that the custom polar logic inLogLocator
was wrong anyway.PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst