-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[ENH] hatch keyword for pie + some pie documentation #24470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this makes sense! |
6c6218e
to
60f9af8
Compare
a74fa53
to
7b7c8fa
Compare
625d2e6
to
520480b
Compare
I don't think the failing tests are connected to this PR 😟 |
Test failures are unrelated. |
I wrote alt text for the what's new entry here but should I just put that as a follow up so this doesn't go through another round of reviews? |
You can add it here if you want to update and get #24921 in to fix CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just one question, which is either a quick fix or I'm missing something. Either way happy for this to be merged once it's been considered!
reworded pctdistance and labeldistance b/c of matplotlib#24789 Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com> Co-authored-by: sledziu32 <sledziu32@gmail.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
…470-on-v3.7.x Backport PR #24470 on branch v3.7.x ([ENH] hatch keyword for pie + some pie documentation)
PR Summary
Added the ability to pass in a list of wedgeproperty dicts, one for each wedge of the pie. Follow on to #2923, would probably address #3134 , inspired by twitter convoYes, I know it can be achieved via loop - see the fig comparison test in this PR - but we were already looping over the wedges inside the function to set all the other properties so the major addition is testing if the input is a dict or list of dicts. <- this could possibly be factored into a cbook function, my guess being 'if thing not list wrap in repeat' is not uncommon in the codebase.
Current Iteration
which would produce roughly
I'll put in a what's new and example if there's consensus on this going in.
PR Checklist
Tests and Styling
pytest
passes).Documentation
Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst