Fix testing of whether backends use the new pyplot_show API. #24527
+28
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comment in pyplot.py explaining the change, and the associated tests. I chose to directly break backcompat on backend_template (removing the global show) as that backend essentially serves as documentation of how to define a backend, so it seems better to directly showcase the encouraged approach.
timhoffm
approved these changes
Nov 21, 2022
oscargus
approved these changes
Nov 23, 2022
oscargus
reviewed
Nov 23, 2022
| ``backend_template.show`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| ... has been removed, in order to better demonstrate the new backend definition | ||
| API. |
There was a problem hiding this comment.
Seems like both me and @timhoffm missed the name of this file...
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in pyplot.py explaining the change, and the associated tests.
I chose to directly break backcompat on backend_template (removing the global show) as that backend essentially serves as documentation of how to define a backend, so it seems better to directly showcase the encouraged approach.
See #24524.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst