Skip to content

Transform ParasiteAxesBase._update_viewlim into standard callback. #24529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Transform ParasiteAxesBase._update_viewlim into standard callback. #24529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/prev_api_changes/api_changes_3.6.0/removals.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ The following class methods have been removed:
``RendererAgg.tostring_rgba_minimized()``
- ``NavigationToolbar2Wx.get_canvas()``

- ``ParasiteAxesBase.update_viewlim()``; use `.ParasiteAxesBase.apply_aspect`
- ``ParasiteAxesBase.update_viewlim()``; use ``ParasiteAxesBase.apply_aspect``
instead.
- ``Subplot.get_geometry()``; use ``SubplotBase.get_subplotspec`` instead.
- ``Subplot.change_geometry()``; use ``SubplotBase.set_subplotspec`` instead.
Expand Down
19 changes: 9 additions & 10 deletions lib/mpl_toolkits/axes_grid1/parasite_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ def clear(self):
super().clear()
martist.setp(self.get_children(), visible=False)
self._get_lines = self._parent_axes._get_lines
self._parent_axes.callbacks._connect_picklable(
"xlim_changed", self._sync_lims)
self._parent_axes.callbacks._connect_picklable(
"ylim_changed", self._sync_lims)

def pick(self, mouseevent):
# This most likely goes to Artist.pick (depending on axes_class given
Expand Down Expand Up @@ -52,23 +56,18 @@ def set_viewlim_mode(self, mode):
def get_viewlim_mode(self):
return self._viewlim_mode

def _update_viewlim(self): # Inline after deprecation elapses.
viewlim = self._parent_axes.viewLim.frozen()
def _sync_lims(self, parent):
viewlim = parent.viewLim.frozen()
mode = self.get_viewlim_mode()
if mode is None:
pass
elif mode == "equal":
self.axes.viewLim.set(viewlim)
self.viewLim.set(viewlim)
elif mode == "transform":
self.axes.viewLim.set(
viewlim.transformed(self.transAux.inverted()))
self.viewLim.set(viewlim.transformed(self.transAux.inverted()))
else:
_api.check_in_list([None, "equal", "transform"], mode=mode)

def apply_aspect(self, position=None):
self._update_viewlim()
super().apply_aspect()

# end of aux_transform support


Expand Down Expand Up @@ -140,9 +139,9 @@ def draw(self, renderer):
self._children = self._children[:orig_children_len]

def clear(self):
super().clear()
for ax in self.parasites:
ax.clear()
super().clear()

def pick(self, mouseevent):
super().pick(mouseevent)
Expand Down