FIX: VPacker and HPacker bottom/top alignment #24570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Nov 30, 2022
timhoffm
reviewed
Nov 30, 2022
| elif align == "center": | ||
| y_height = (y2 - y1) / 2 | ||
| # x-offsets, y-offsets | ||
| assert_allclose([(0, y_height), (x1, 0)], extents[-1]) |
There was a problem hiding this comment.
Suggested change
| assert_allclose([(0, y_height), (x1, 0)], extents[-1]) | |
| assert_allclose([(0, y_height), (x1, 0)], offset_pairs) |
The bottom and top alignments were incorrectly defined before, this updates them to have the expected alignment.
8a5f0ff to
b51c471
Compare
timhoffm
approved these changes
Nov 30, 2022
jklymak
approved these changes
Nov 30, 2022
|
Anyone should merge when CI is done... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The bottom and top alignments were incorrectly defined before, this updates them to have the expected alignment.
closes #24386
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst