Skip to content

Shorten demo_axes_grid example. #24582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Shorten demo_axes_grid example. #24582

merged 1 commit into from
Dec 3, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 2, 2022

Get rid of the individual example functions, as they are not really independent from one another anyways (given that they use absolute subplot positioning onto the main figure). This also allows not having to reload the sample data in each function, and thus concentrate more on showcasing the ImageGrid functionality.

Group some kwargs to ImageGrid in a single line; e.g. the cbar arguments clearly logically belong together.

Inspired by the point about example length at https://discourse.matplotlib.org/t/new-approach-to-matplotlib-example-galleries/23359.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Get rid of the individual example functions, as they are not really
independent from one another anyways (given that they use absolute
subplot positioning onto the main figure).  This also allows not having
to reload the sample data in each function, and thus concentrate more on
showcasing the ImageGrid functionality.

Group some kwargs to ImageGrid in a single line; e.g. the cbar arguments
clearly logically belong together.
@tacaswell tacaswell merged commit 432b876 into matplotlib:main Dec 3, 2022
@anntzer anntzer deleted the dag branch December 3, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants