Fix: Gracefully fail the string validator for tuple inputs #24600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially closes - matplotlib#22338
oscargus
approved these changes
Dec 3, 2022
tacaswell
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 3, 2022
…or for tuple inputs
|
Thank you @iofall and congratulations on your first merged Matplotlib PR 🎉 It was great to work with you at the sprint and I hope we hear from you again! |
oscargus
added a commit
that referenced
this pull request
Dec 4, 2022
…600-on-v3.6.x Backport PR #24600 on branch v3.6.x (Fix: Gracefully fail the string validator for tuple inputs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes - #22338
PR Summary
Gracefully fail the string validator when tuple values are provided to rcParams. Addresses the first part of the issue.
PR Checklist
Documentation and Tests
pytestpasses)