-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add "sage" colors to colors.py #2468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A Sage user commented that one couldn't make plots in Sage "sage". But this is a color. http://xkcd.com/color/rgb/ recommends the following, and the discussion at https://groups.google.com/forum/#!topic/sage-devel/CnH45Ym4zSk indicates it could be useful as well as fun.
Naturally, if this is viewed as too silly, no worries - just say no. But I think we're unlikely to find any other more authoritative source for these colors - a quick search reveals only "sage" as part of palettes that people made up for their own purposes (like branding). |
I have nothing fundamentally against this. |
Documentation will need to be updated. Currently, the list of available |
You mean http://www.w3.org/TR/css3-color/#svg-color in particular? If that is indeed exactly the same list, then maybe it wouldn't be wise to add to that list unless W3C does. Of course, we could just hack our own copy of mpl or add it to our color module, but that might be a bit kwazy. |
I'm not sure why this fails on the Python 2.6 build - only. |
I think that failure is unrelated to this PR and can be ignored. |
I'm in favour of this color addition, but it is worth noting that there are a further 845 colors in the XKCD colors which are not in matplotlib: http://nbviewer.ipython.org/6900318 I've been meaning to get around to looking at the whole of colors and cm - perhaps this is my way in 😉 |
Why do all roads lead back to xkcd? 😉 |
I think this is worth merging as-is. There is no need to hold this up on including the rest of that list. |
A Sage user commented that one couldn't make plots in Sage "sage". But this is a color. http://xkcd.com/color/rgb/ recommends the following, and the discussion at https://groups.google.com/forum/#!topic/sage-devel/CnH45Ym4zSk indicates it could be useful as well as fun.