MEP12: Example clean-up for reference #2474
Conversation
The original example was trying to do too much in one place.
Remove plot of exact PDF since this is already demoed in another example.
The example linked in backend_driver was broken when examples were split up and renamed/moved.
|
That looks good to me. Are we sure that there are no explicit links to this example in the documentation ? Also, can you squash some of those commits. That's a long list for the size of the patch :) Else, I'm 👍 |
|
I am against squashing this. That list is an excellent bulletted list of |
|
Squashing commits doesn't mean removing the content of the commit messages. |
|
Actually, I wanted to be as specific as possible with each commit. There were a few I might have wanted to group together, but for the most part each one gives a good, isolated description of different types of changes. This is important because I use these commits as concrete examples in the MEP (which links directly to commits). And yes, as far as I can tell, none of the docs link to this example. |
|
Is there any reason this has not been merged? |
MEP12: Example clean-up for reference
This PR is meant as a reference for clean-ups that should take place as part of the Gallery clean ups outlined in MEP12.