-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Fix duplicate redirect #24795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix duplicate redirect #24795
Conversation
The example /gallery/pyplots/dollar_ticks is included into the artists tutorial. matplotlib#24054 Moved that example and added a `.. redirect-from::` directive. This was then duplicated by the include. This PR fixes the issue by moving the include start point after the redirect.
The error messages from this failing seem mysterious - do we need to improve the directive to return clearer messages, or even do basic error checking for this sort of duplication? |
I don't think you can (reasonably simple) distinguish this error from a case where the user has explicitly written a duplicate redirect. Let's just fix this and get on with life. If it happens more often inn the future we can always rethink whether we find a better solution. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
If there are merge conflicts, we likely do not need to backport. |
The example /gallery/pyplots/dollar_ticks is included into the artists tutorial. #24054 Moved that example and added a
.. redirect-from::
directive. This was then duplicated by the include.This PR fixes the issue by moving the include start point after the redirect.
Closes #24058.