Skip to content

Deprecate 'x' argument for widgets.TextBox.begin_typing #24806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2022
Merged

Deprecate 'x' argument for widgets.TextBox.begin_typing #24806

merged 2 commits into from
Dec 22, 2022

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Dec 22, 2022 •
edited
Loading

PR Summary

This argument is a holdover from seemingly a debugging print statement
that has long since been removed.

It is not used internally, and was passed entirely different things in
the two places it was called (once in tests, once in library code).

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
    • no docstring to begin with, not sure its worth adding for just an already unused argument being deprecated
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@ksunden
Deprecate 'x' argument for widgets.TextBox.begin_typing
354f1a8 
This argument is a holdover from seemingly a debugging print statement
that has long since been removed.

It is not used internally, and was passed entirely different things in
the two places it was called (once in tests, once in library code).
@ksunden
release note for unused variable
32cac5c
@QuLogic QuLogic added this to the v3.7.0 milestone Dec 22, 2022
@timhoffm timhoffm merged commit 1d13d2d into matplotlib:main Dec 22, 2022
@ksunden ksunden deleted the begin_typing_arg branch December 27, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: widgets/UI
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ksunden @QuLogic @timhoffm