[Doc] expanded basic pie example #24812
Conversation
|
Hard restarting the PR doesn't restart circle I guess. @story645 you will have to rebase on master to get |
|
Shouldn't the title for the page change? Otherwise looks good. |
To 'Bar Chart`? and what do you think about this sorta model for documenting at least plotting and other common methods? I'm honestly thinking of it as a sorta visual API doc, b/c a major advantage of being a viz library is that we can visualize a lot of the API. It ends up inherently being a bit of a how to too, but I think it's one way to address the problem of inconsistent naming of things across visualization libraries. |
|
"Pie charts"? |
🤦♀️ clearly I'm sleep deprived |
11d528d to
00cff21
Compare
|
circle is caught because it's using the pre-merge config (which specifies python 3.8) but post-merge code (and setup.py, which specifies 3.9 as the minimum) Should be resolved with a rebase, which will have the up to date circle config. |
58e3f79 to
9d04a5c
Compare
|
You have some |
added small examples of labels, autopct, colors, hatch, and distance in an attempt to scaffold up to exploding example addresses some of matplotlib#24789 Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com> Co-authored-by: David Stansby <dstansby@gmail.com>
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
|
Oh right, the |
…v3.7.x Backport PR #24812 on branch v3.7.x ([Doc] expanded basic pie example)
added small examples of labels, autopct, colors, hatch, and distance in an attempt to scaffold up to exploding example. I also kinda really like this model of documenting the plotting methods - small isolated example of each notable keyword - so if other folks do too, this could be a way to consolidate some of the examples. It's also a style I'm seeing a lot in blog posts and social media tutorials so I think it's popular. (ETA: also is how the subplot mosaic guide is written, see 24891)
Plus the section headers make the navigation really nice:
Pulled this out of #24470 to make reviewing easier, so this also documents the
hatchkeyword introduced there & therefore all the things will break until that PR is merged. Also tries to address some of #24789