Skip to content

[MNT] Improve variable naming in bar #24832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

oscargus
Copy link
Member

PR Summary

Inspired by https://github.com/matplotlib/matplotlib/pull/22314/files#r793095283

This was the location where I think it made a difference. For example, height = top - bottom is quite a bit clearer than height = m - bottom.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@dstansby dstansby added this to the v3.7.0 milestone Dec 29, 2022
@dstansby dstansby merged commit 3393a4f into matplotlib:main Dec 29, 2022
@oscargus oscargus deleted the bar_variable_naming branch December 29, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants