changed method in animation tutorial table of methods #24841
Conversation
|
Thanks! It did indeed start as a circle but I changed it to Ellipse since all the base methods came from Ellipse. The reason, I think, I had |
|
figured it was something like that - does |
|
I think I'd prefer the second one so that it's clear. |
9409dd0 to
f84f0cf
Compare
| # `.Rectangle.set_height`, | ||
| # `.Rectangle.set_width`, | ||
| # `.Rectangle.set_x`, | ||
| # `.Rectangle.set_y` |
There was a problem hiding this comment.
| # `.Rectangle.set_y` | |
| # `.Rectangle.set_y`, |
|
I'm not saying that I fully understand the idea here (either before or after this PR), especially if there are commas left out on purpose or just missing (the one I marked is an old one, but there I am quite sure it is simply missing). It may be worth noting that I have not been able to get both Shouldn't |
| # `.Ellipse.set_center`, | ||
| # `.Ellipse.set_height`, | ||
| # `.Ellipse.set_width` |
There was a problem hiding this comment.
Should be in the 3rd column, no?
There was a problem hiding this comment.
yeah messed up spacing but don't have time to change this to list-table, fixing
Co-authored-by: Chahak Mehta <chahakmehta013@gmail.com>
f84f0cf to
8f4f084
Compare
figured this out, solution was to escape the parenthesis. also abbreviated the set method so that the table won't overflow |
The animation tutorial has a table of plotting methods and the underlying artists to illustrate what to look for in the docs. I didn't catch on review that this has patches.Circle as the first entry.
Since Ellipse isn't the underlying patch I change the first entry to
Axes.add_patchb/c I like 'em all as axes methods, but I'm unsure of @chahak13 intent here. (My guess is the example started as circle and morphed to ellipse)