Skip to content

Fix toggling of MultiCursor.{horizOn,vertOn} #24845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix toggling of MultiCursor.{horizOn,vertOn} #24845

merged 1 commit into from
Jan 3, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 30, 2022 •
edited
Loading

PR Summary

By implementing _onmove in a similar manner to Cursor. Also, deprecate the related needclear attribute in both widgets.

Followup to #19763.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added this to the v3.7.0 milestone Dec 30, 2022
@QuLogic
Fix toggling of MultiCursor.{horizOn,vertOn}
2040a32 
By implementing `_onmove` in a similar manner to `Cursor`. Also,
deprecate the related `needclear` attribute in both widgets.

Followup to matplotlib#19763.
@QuLogic QuLogic mentioned this pull request Dec 30, 2022
Merged
5 tasks
@ksunden ksunden merged commit 6efcfed into matplotlib:main Jan 3, 2023
@QuLogic QuLogic deleted the cursor-disable branch January 4, 2023 01:11
@ksunden ksunden mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden approved these changes

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @ksunden @greglucas