Skip to content

Promote pending cm deprecations to full deprecations #24846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2022
Merged

Promote pending cm deprecations to full deprecations #24846

merged 1 commit into from
Dec 31, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 30, 2022

PR Summary

This is the next stage of #20853.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added this to the v3.7.0 milestone Dec 30, 2022
dstansby
dstansby approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small non-blocking question

ksunden
ksunden reviewed Dec 31, 2022
View reviewed changes
@ksunden ksunden merged commit 88e43f3 into matplotlib:main Dec 31, 2022
@QuLogic QuLogic deleted the cm-deprecations branch December 31, 2022 05:56
@QuLogic QuLogic mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksunden ksunden ksunden left review comments

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Maintenance topic: color/color & colormaps
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @ksunden @dstansby