Skip to content

make pep8 test routine reusable for other projects #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2013
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
correct current skipping of pep8 tests for nose test discovery
  • Loading branch information
megies committed Oct 2, 2013
commit af6c60758146b05e0131fa8b368411ebbf2cc2a4
13 changes: 8 additions & 5 deletions lib/matplotlib/tests/test_coding_standards.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ def get_file_results(self):
return self.file_errors


def test_pep8_conformance(module=matplotlib, exclude_files=EXCLUDE_FILES,
extra_exclude_file=EXTRA_EXCLUDE_FILE,
pep8_additional_ignore=PEP8_ADDITIONAL_IGNORE):
def assert_pep8_conformance(module=matplotlib, exclude_files=EXCLUDE_FILES,
extra_exclude_file=EXTRA_EXCLUDE_FILE,
pep8_additional_ignore=PEP8_ADDITIONAL_IGNORE):
"""
Tests the matplotlib codebase against the "pep8" tool.

Expand Down Expand Up @@ -246,8 +246,11 @@ def test_pep8_conformance(module=matplotlib, exclude_files=EXCLUDE_FILES,
'{}'.format('\n '.join(unexpectedly_good)))


## Temporarily disabling test
#def test_pep8_conformance():
# assert_pep8_conformance()


if __name__ == '__main__':
import nose
# Temporarily disabling test
raise nose.SkipTest('Test is disabled in the code')
nose.runmodule(argv=['-s', '--with-doctest'], exit=False)