Skip to content

Add parameter type (links) for mpl_toolkits #24860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add parameter type (links) for mpl_toolkits #24860

wants to merge 1 commit into from

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Jan 1, 2023

PR Summary

Related to #24859

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@timhoffm
Copy link
Member

timhoffm commented Jan 3, 2023

Have you considered using :ref: rather than :doc:? #24859 (comment)

dstansby
dstansby requested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comment @timhoffm linked above, that using :ref: is better than using :doc:, so I'll mark as requesting changes.

@oscargus oscargus marked this pull request as draft April 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby requested changes

@ksunden ksunden ksunden approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Documentation status: needs rebase topic: mpl_toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oscargus @timhoffm @ksunden @dstansby