Skip to content

FIX: error in formatting in error string in redirect extension #24892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

tacaswell
Copy link
Member

otherdata is a dict

PR Summary

Given that this is a helper sphinx extension that we do not ship, I do no think we need a test (but this error existing made debugging a build issues easy!).

@tacaswell tacaswell added this to the v3.7.0 milestone Jan 6, 2023
@QuLogic
Copy link
Member

QuLogic commented Jan 6, 2023

LGTM, but I do not understand the commit/PR title.

@tacaswell
Copy link
Member Author

It is an error in the format string, I'll make it clearer.

@tacaswell
Copy link
Member Author

and in 'in' -> 'is' typo.

@tacaswell tacaswell changed the title FIX: error formatting in error is redirect extension FIX: error in formatting in error string in redirect extension Jan 6, 2023
@oscargus oscargus merged commit 1df1c06 into matplotlib:main Jan 6, 2023
@tacaswell tacaswell deleted the fix_sphinx_error branch January 6, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants