FIX: error in formatting in error string in redirect extension #24892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee8e691 to
f055402
Compare
|
LGTM, but I do not understand the commit/PR title. |
|
It is an error in the format string, I'll make it clearer. |
|
and in 'in' -> 'is' typo. |
`otherdata` is a dict
f055402 to
95ab16f
Compare
QuLogic
approved these changes
Jan 6, 2023
oscargus
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherdatais a dictPR Summary
Given that this is a helper sphinx extension that we do not ship, I do no think we need a test (but this error existing made debugging a build issues easy!).