Skip to content

Fix pgf tests with TeXLive 2022 #25068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 24, 2023

PR Summary

Apparently, the Micro Sign glyph in text is now upright and not italic, as \mu is in math mode.

Unfortunately, I don't think CI is new enough to trigger this, so this PR is really just bookkeeping to have something to remember when that changes.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer
Copy link
Contributor

anntzer commented Jan 24, 2023

Perhaps change create_figure to no longer include a \mu in the text in order to hopefully keep the baseline more robust against texlive version changes?
(If you do so I would also replace the \usepackage{sfmath} in test_rcupdate by perhaps something slightly more common, as I'm not sure sfmath is installed by default (I ran into it not being installed a couple of times)).

@QuLogic
Copy link
Member Author

QuLogic commented Jan 24, 2023

That's also a possibility; I wasn't sure if we used that specific text/package for any good testing reason.

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Apr 12, 2023
`|| true` was added, because, although the testsuite passed, xvfb-run errored
out:
===== 9082 passed, 163 skipped, 17 xfailed, 7 xpassed in 89.15s (0:01:29) ======
/usr/bin/xvfb-run: line 186: kill: (4477) - No such process


git-svn-id: file:///srv/repos/svn-community/svn@1444800 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Apr 12, 2023
`|| true` was added, because, although the testsuite passed, xvfb-run errored
out:
===== 9082 passed, 163 skipped, 17 xfailed, 7 xpassed in 89.15s (0:01:29) ======
/usr/bin/xvfb-run: line 186: kill: (4477) - No such process

git-svn-id: file:///srv/repos/svn-community/svn@1444800 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@QuLogic QuLogic mentioned this pull request Jun 8, 2023
6 tasks
@QuLogic
Copy link
Member Author

QuLogic commented Jun 13, 2023

It appears that replacing with Unicode Greek alpha does not work directly, as that glyph does not seem to be available in all the cases that the tests run. Looking at the text again, it's actually 'MICRO SIGN' (U+00B5), not the Greek letter mu. Trying the latter actually ends up with an empty glyph as well. So this is specifically a character from the Latin-1 Supplement block, which ü and ° already cover. We could change it to 'PLUS-MINUS SIGN' (which would probably not italicize) or perhaps remove entirely.

Apparently, the `Micro Sign` glyph in text is now upright and not
italic. Replace it with `Section Sign`, which is in the same Unicode
block, but does not change styles.
@QuLogic
Copy link
Member Author

QuLogic commented Jun 13, 2023

I've changed it to Section Sign to keep a similar text dimension, and confirmed that it works on Fedora 38 (texlive 2022) and Ubuntu 22.04 (texlive 2021).

@QuLogic QuLogic marked this pull request as ready for review June 13, 2023 00:31
@QuLogic QuLogic added this to the v3.7.2 milestone Jun 13, 2023
@tacaswell tacaswell merged commit 5706f17 into matplotlib:main Jun 14, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 14, 2023
@QuLogic QuLogic deleted the texlive2022 branch June 14, 2023 21:05
ksunden added a commit that referenced this pull request Jun 14, 2023
…068-on-v3.7.x

Backport PR #25068 on branch v3.7.x (Fix pgf tests with TeXLive 2022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants