AutoDateFormatter: More customizable formatting #2507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows custom functions to be used for formatting in the style of FuncFormatter. Also in AutoDateFormatter.__call__() the `pos` kwarg should default to `None` I think.
by matplotlib (show usage with `FuncFormatter`)
| @@ -545,8 +561,13 @@ def __call__(self, x, pos=0): | |||
| fmt = self.scaled[k] | |||
| break | |||
|
|
|||
| self._formatter = DateFormatter(fmt, self._tz) | |||
| return self._formatter(x, pos) | |||
| if isinstance(fmt, basestring): | |||
There was a problem hiding this comment.
I think you need to use six.string_type here. @mdboom?
|
Ok, thanks. Sorry to not think of the compatibility layering myself.. |
megies
added a commit
to megies/obspy
that referenced
this pull request
Oct 9, 2013
might be directly in newer matplotlib (see matplotlib/matplotlib#2507) but we want this to work with older matplotlib, too
|
@megies - are you familiar with mock? I think this enhancement would be well suited to a mock test, if your game? |
|
@pelson - actually, I haven't used mock so far and am not really familiar with how to use it best. What aspect and how would you want mock-tested? |
|
@pelson Do you want to hold this until there is a |
| elif six.callable(fmt): | ||
| return fmt(x, pos) | ||
| else: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
This should probably raise a more descriptive error.
|
Closing in favour of #2707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AutoDateFormatteris a great tool, one does not have to worry about the scaling of the time range. However, I found for myself that only having astrftimeformat string as control is not enough. In particular I found it annoying to not be able to get rid of all-zero decimal seconds where possible and have decimal seconds show up where there really are dcimal seconds.The example I added in the docstring should make clear what I mean.
This PR allows custom functions to be used for formatting in the style of
FuncFormatter.EDIT: I changed the docstring example to using a FuncFormatter so that it looks less hackish and uses matplotlib classes.
I will have to inherit/override this in our project (so that it works across matplotlib versions), but I thought this might be useful for other matplotlib users in future versions as well.
Also in
AutoDateFormatter.__call__()theposkwarg should default toNonerather than0, I think.