Skip to content

Backport PR #23442 on branch v3.7.x (Remove need to detect math mode in pgf strings) #25095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #23442: Remove need to detect math mode in pgf strings

@lumberbot-app lumberbot-app bot added this to the v3.7.0 milestone Jan 27, 2023
@tacaswell
Copy link
Member

This seems a bit risky to backport between rc and final (because I do not understand it), happy to be told it is fine by someone who does :)

@ksunden
Copy link
Member

ksunden commented Jan 27, 2023

I was admittedly on the bubble about whether I wanted to backport or not (or hold off on merging until 3.7.0 final was out but still backport for 3.7.1, I guess)

Ended up at "probably not requisite of being pushed all the way to 3.8, don't see anything that requires changes"

I welcome @anntzer's thoughts as the original author here.

@anntzer
Copy link
Contributor

anntzer commented Jan 27, 2023

The PR does fix a long-standing bug, but the fix is a bit subtle and I don't think it's overly urgent to get it in.

@jklymak
Copy link
Member

jklymak commented Feb 8, 2023

I'll close so that we have to live with it on master for a while, but feel free to re-open and resubmit, I don't feel strongly about it (or particularly understand the PR details)

@jklymak jklymak closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants