Deprecate LocationEvent.lastevent. #25101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9fc4e5 to
6b7e181
Compare
Keeping around lastevent can delay garbage collection of a torn-down axes, and can also keep around an actual GUI event object (guiEvent) associated with a long-torn down widget, which can be problematic for some GUI toolkits. Instead, only keep track of the last inaxes attribute. Unfortunately there are no tests for axes_enter_event/axes_leave_event, but this can be manually tested by running the event_handling/figure_axes_enter_leave.py example.
greglucas
approved these changes
Feb 7, 2023
ksunden
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping around lastevent can delay garbage collection of a torn-down axes, and can also keep around an actual GUI event object (guiEvent) associated with a long-torn down widget, which can be problematic for some GUI toolkits.
Instead, only keep track of the last inaxes attribute.
Unfortunately there are no tests for axes_enter_event/axes_leave_event, but this can be manually tested by running the
event_handling/figure_axes_enter_leave.py example.
See #24820, #22211 (comment).
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst