Stop recommending ncol in legend examples
#25110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 958e329 the preferred keyword for controlling the number of columns in a legend is `ncols`, but some code examples have still been using `ncol`.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
rcomer
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Thanks @eerovaher! I think we just need to wait for the CI to pass…
ksunden
approved these changes
Jan 30, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 30, 2023
jklymak
added a commit
that referenced
this pull request
Jan 31, 2023
…110-on-v3.7.x Backport PR #25110 on branch v3.7.x (Stop recommending `ncol` in legend examples)
|
Thank you for submitting your first PR to Matplotlib @eerovaher. We hope to hear from you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Since 958e329 the preferred keyword for controlling the number of columns in a legend is
ncols. However,reveals several uses of the old keyword. This pull request replaces most of them with the new recommended
ncols, but three uses ofncolshould remain in place:matplotlib/doc/users/prev_whats_new/whats_new_0.98.4.rst
Line 40 in a30c0b1
matplotlib/lib/matplotlib/legend.py
Line 383 in a30c0b1
matplotlib/lib/matplotlib/tests/test_legend.py
Line 1220 in a30c0b1
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst