Whisker length, more precise description #25135
Conversation
See issue for discussion. matplotlib#25134 (comment)
lib/matplotlib/axes/_axes.py
Outdated
| quartile (Q3) of the data, with a line at the median. The | ||
| whiskers extend from the box to the farthest point within | ||
| 1.5x the inter-quartile range (IQR) distance. Flier points | ||
| are those past the end of the whiskers. |
There was a problem hiding this comment.
Maybe?
| quartile (Q3) of the data, with a line at the median. The | |
| whiskers extend from the box to the farthest point within | |
| 1.5x the inter-quartile range (IQR) distance. Flier points | |
| are those past the end of the whiskers. | |
| quartile (Q3) of the data, with a line at the median. The | |
| whiskers extend from the box to 1.5x the inter-quartile | |
| range (IQR) distance from the median. Flier points | |
| are those past the end of the whiskers. |
There was a problem hiding this comment.
And actually I'm confused - is the ASCII art also incorrect?
There was a problem hiding this comment.
No!
It's 1.5x IQR from the edge of the box, so low = Q1 - 1.5 * IQR location of the median has no influence here
There was a problem hiding this comment.
OK, well, its still not clear then, but at least the ASCII art is correct...
There was a problem hiding this comment.
Also the whole point of this change was to explain why sometimes whiskers are asymmetric (see #25134 (comment)) and the proposal above #25135 (comment) doesn't resolve that.
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
There is an unresolved discussion over wording.
Change to consensus wording See: https://github.com/matplotlib/matplotlib/pull/25135/files#r1095049218
remove trailing whitespace
|
I took the liberty of squash merging. Thanks a lot for fixing this and we hope to hear from you again... |
See issue for discussion.
#25134 (comment)
PR Summary
Slight change of the documentation wording to make it more precise.
PR Checklist
Documentation and Tests
Not applicable: - [ ] Has pytest style unit tests (and
pytestpasses)Not applicable: - [ ] New plotting related features are documented with examples.