Skip to content

added layout="compressed" for pyplot #25223 #25234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 19, 2023
Merged

added layout="compressed" for pyplot #25223 #25234

merged 7 commits into from
Feb 19, 2023

Conversation

RishabhSpark
Copy link
Contributor

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

github-actions[bot]
github-actions bot reviewed Feb 16, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

jklymak
jklymak reviewed Feb 16, 2023
View reviewed changes
@jklymak jklymak added status: needs revision topic: geometry manager LayoutEngine, Constrained layout, Tight layout API: consistency labels Feb 16, 2023
@RishabhSpark @jklymak
Update lib/matplotlib/pyplot.py
ba3dbc9 
Co-authored-by: Jody Klymak <jklymak@gmail.com>
jklymak
jklymak reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new line is still too long (89>88).

@oscargus oscargus changed the title added layout="none" and "compressed" for pyplot #25223 added layout="compressed" for pyplot #25223 Feb 17, 2023
@RishabhSpark
Copy link
Contributor Author

The new line is still too long (89>88).

Hi, sorry but I'm new to open source and matplotlib, can you help me out with the error please? :D

@rcomer
Copy link
Member

rcomer commented Feb 17, 2023

Here is an example where the type descriptions are continued on the next line to keep within the line length limit:

matplotlib/lib/matplotlib/offsetbox.py

Lines 1257 to 1258 in 2b05ace

xycoords : single or two-tuple of str or `.Artist` or `.Transform` or \
callable, default: 'data'

@rcomer rcomer added this to the v3.7.1 milestone Feb 19, 2023
@rcomer rcomer merged commit 0ed7cf5 into matplotlib:main Feb 19, 2023
@rcomer
Copy link
Member

rcomer commented Feb 19, 2023

Thanks @RishabhSpark!

@meeseeksmachine meeseeksmachine mentioned this pull request Feb 19, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 19, 2023
@RishabhSpark @meeseeksmachine
Backport PR matplotlib#25234: added layout="compressed" for pyplot ma…
6df5f27 
…tplotlib#25223
oscargus added a commit that referenced this pull request Feb 20, 2023
@oscargus
Merge pull request #25260 from meeseeksmachine/auto-backport-of-pr-25…
3e173f9 
…234-on-v3.7.x

Backport PR #25234 on branch v3.7.x (added layout="compressed" for pyplot #25223)
robrighter pushed a commit to robrighter/matplotlib that referenced this pull request Feb 20, 2023
@RishabhSpark @jklymak @robrighter
added layout="compressed" for pyplot matplotlib#25223 (matplotlib#25234)
775ad94 
* layout none and compressed added in pyplot

* Update lib/matplotlib/pyplot.py

Co-authored-by: Jody Klymak <jklymak@gmail.com>

* compressed added

* fixed (89>88) error ig(?)

---------

Co-authored-by: Jody Klymak <jklymak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
API: consistency Documentation topic: geometry manager LayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@RishabhSpark @rcomer @jklymak @oscargus