Skip to content

Re-enable CI buildwheel and cygwin labels #25236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

Re-enable CI buildwheel and cygwin labels #25236

merged 1 commit into from
Feb 17, 2023

Conversation

oscargus
Copy link
Member

PR Summary

I guess this was renamed recently?

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus added the CI: Run cibuildwheel Run wheel building tests on a PR label Feb 16, 2023
jklymak
jklymak approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies - I renamed this; I had no idea it was being used for a workflow. Alternative is to change the name back. Note I also changed the Cygwin name.

Perhaps in the description, we can be more draconian: "DON'T RENAME AS IT BREAKS AN ACTION" ?

@tacaswell
Copy link
Member

While you are doing this can you fix the cgywn one as well?

@tacaswell
Copy link
Member

I also wonder if in the GHA it is possible to grab the label id rather than the name (which should be stable over time!)?

@oscargus oscargus force-pushed the restorecibuildwheel branch from 579f66f to cb89168 Compare February 17, 2023 04:45
@oscargus oscargus changed the title Re-enable CI buildwheel label Re-enable CI buildwheel and cygwin labels Feb 17, 2023
@oscargus oscargus added the CI: Run cygwin Run cygwin tests on a PR label Feb 17, 2023
@oscargus
Copy link
Member Author

Added Cygwin as well.

Couldn't figure out which members are available for the events...

Probably this should be backported? Thinking that otherwise one cannot do this for backported PRs? Like the qhull LICENSE issue?

@ksunden ksunden added this to the v3.7.1 milestone Feb 17, 2023
@ksunden ksunden merged commit 60f0175 into matplotlib:main Feb 17, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 17, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 60f01751c0bfb486dec45faf1c494e4c1042f236
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25236: Re-enable CI buildwheel and cygwin labels'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25236-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #25236 on branch v3.7.x (Re-enable CI buildwheel and cygwin labels)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

ksunden added a commit to ksunden/matplotlib that referenced this pull request Feb 17, 2023
@ksunden
Backport PR matplotlib#25236: Re-enable CI buildwheel and cygwin labels
8994868 
Re-enable CI buildwheel and cygwin labels

Note: cygwin ci does not exist on v3.7.x, so cygwin changes are omitted

(cherry picked from commit 60f0175)
@ksunden
Copy link
Member

ksunden commented Feb 17, 2023

Cygwin ci does not exist for 3.7.x, so the changes to cygwin are not backported

rcomer added a commit that referenced this pull request Feb 20, 2023
@rcomer
Merge pull request #25245 from ksunden/auto-backport-of-pr-25236-on-v…
a8f3b5b 
…3.7.x

Backport PR #25236: Re-enable CI buildwheel and cygwin labels
@oscargus oscargus deleted the restorecibuildwheel branch February 21, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@ksunden ksunden ksunden approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheel Run wheel building tests on a PR CI: Run cygwin Run cygwin tests on a PR
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@oscargus @tacaswell @ksunden @jklymak