Skip to content

CI: Pin reviewdog eslint to use node 18.13 #25262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2023
Merged

CI: Pin reviewdog eslint to use node 18.13 #25262

merged 1 commit into from
Feb 20, 2023

Conversation

greglucas
Copy link
Contributor

PR Summary

The reviewdog action is not compatible with npm v9 yet, and node 18.14+ comes with npm v9+.

closes #25251

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@greglucas
CI: Pin reviewdog eslint to use node 18.13
88d109f 
The reviewdog action is not compatible with npm v9 yet, and node 18.14+
comes with npm v9+.
@jklymak jklymak added the CI: testing CI configuration and testing label Feb 19, 2023
@rcomer rcomer added this to the v3.7.1 milestone Feb 20, 2023
@rcomer rcomer merged commit de8e9d0 into matplotlib:main Feb 20, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 20, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 20, 2023
@rcomer @meeseeksmachine
Backport PR matplotlib#25262: CI: Pin reviewdog eslint to use node 18.13
50d3a5d
rcomer added a commit that referenced this pull request Feb 20, 2023
@rcomer
Merge pull request #25264 from meeseeksmachine/auto-backport-of-pr-25…
8099c7d 
…262-on-v3.7.x

Backport PR #25262 on branch v3.7.x (CI: Pin reviewdog eslint to use node 18.13)
@greglucas greglucas deleted the ci-reviewdog-eslint branch February 20, 2023 15:24
@rcomer rcomer mentioned this pull request Feb 22, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.

[CI]: eslint failure
3 participants
@greglucas @jklymak @rcomer