Fix setting CSS with latest GTK4 #25280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upcoming 4.10 release, the type annotation was fixed [1]. There may be some overrides added in PyGObject [2] to avoid this difference, but we don't depend on a specific version of it to be able to rely on that (and it's not released yet.) This code should work with the override as well. [1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5441 [2] https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/231
tacaswell
approved these changes
Feb 22, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 22, 2023
ksunden
added a commit
that referenced
this pull request
Feb 22, 2023
…280-on-v3.7.x Backport PR #25280 on branch v3.7.x (Fix setting CSS with latest GTK4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the upcoming 4.10 release, the type annotation was fixed [1]. There may be some overrides added in PyGObject [2] to avoid this difference, but we don't depend on a specific version of it to be able to rely on that (and it's not released yet.) This code should work with the override as well.
[1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5441
[2] https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/231
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst