Skip to content

CI: unpin reviewdog eslint #25283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

CI: unpin reviewdog eslint #25283

merged 1 commit into from
Feb 22, 2023

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Feb 22, 2023

PR Summary

Reverts #25262. Reviewdog just cut a release that I believe should fix the problem:
https://github.com/reviewdog/action-eslint/releases/tag/v1.18.0

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@rcomer rcomer changed the title CI: unpin reviewdog CI: unpin reviewdog eslint Feb 22, 2023
@rcomer rcomer added the CI: testing CI configuration and testing label Feb 22, 2023
@rcomer rcomer added this to the v3.7.1 milestone Feb 22, 2023
@tacaswell tacaswell merged commit 506efe5 into matplotlib:main Feb 22, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 22, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 22, 2023
@tacaswell @meeseeksmachine
Backport PR matplotlib#25283: CI: unpin reviewdog eslint
33e4aa6
@rcomer rcomer deleted the unpin-reviewdog branch February 22, 2023 17:48
jklymak added a commit that referenced this pull request Feb 22, 2023
@jklymak
Merge pull request #25284 from meeseeksmachine/auto-backport-of-pr-25…
f4eac94 
…283-on-v3.7.x

Backport PR #25283 on branch v3.7.x (CI: unpin reviewdog eslint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rcomer @jklymak @tacaswell