Skip to content

Make draggable legends picklable. #25311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

Make draggable legends picklable. #25311

merged 1 commit into from
Feb 27, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 23, 2023

PR Summary

Closes #25300.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

QuLogic
QuLogic reviewed Feb 23, 2023
View reviewed changes
@inxp inxp mentioned this pull request Feb 24, 2023
Closed
@oscargus
Copy link
Member

oscargus commented Feb 26, 2023 •
edited by anntzer
Loading

Note that there is an update in #25300 about pickling after dragging. (This is confirmed to have fixed the original issue.)

@anntzer
Copy link
Contributor Author

anntzer commented Feb 26, 2023

I think that just points in favor of #23882; at least the part "implement BufferRegions on top of plain numpy arrays".

@jklymak jklymak added the topic: pickle Issues to do with pickling label Feb 26, 2023
@QuLogic QuLogic added this to the v3.7.1 milestone Feb 27, 2023
@QuLogic QuLogic merged commit 5e8c140 into matplotlib:main Feb 27, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 27, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 27, 2023
@QuLogic @meeseeksmachine
Backport PR matplotlib#25311: Make draggable legends picklable.
b1342cb
QuLogic added a commit that referenced this pull request Feb 27, 2023
@QuLogic
Merge pull request #25337 from meeseeksmachine/auto-backport-of-pr-25…
673e722 
…311-on-v3.7.x

Backport PR #25311 on branch v3.7.x (Make draggable legends picklable.)
@anntzer anntzer deleted the dlp branch February 28, 2023 07:18
@anntzer anntzer mentioned this pull request Mar 12, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: pickle Issues to do with pickling
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to pickle figure with draggable legend
4 participants
@anntzer @oscargus @QuLogic @jklymak