Adding test for all NANs in contour #25330
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks! I added a line in your original post to automatically close the issue when merged. |
| def test_contour_all_nan(): | ||
| # Smoke test for gh#14124 | ||
| x = np.array([[np.nan, np.nan], [np.nan, np.nan]]) | ||
| with pytest.warns(UserWarning) as w: |
There was a problem hiding this comment.
You should add the match string here rather than asserting on private message lists. https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html#warns
edit: also, the warning text seems a bit misleading here since the user didn't pass in any masked elements.
There was a problem hiding this comment.
There are two warnings, so this should be the way to go.
https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html#recwarn
Edit: I think that those comes from numpy.
Oscar@Beavis MINGW64 ~/matplotlib (main)
$ git grep "Warning: converting a masked element"
Oscar@Beavis MINGW64 ~/matplotlib (main)
$ git grep "converting a masked element"
There was a problem hiding this comment.
As @oscargus mentioned, There are two warnings, so I manually checked the warning messages for both.
Yes, the warning message is coming from numpy.
/usr/lib/python3/dist-packages/numpy/ma > grep "Warning: converting a masked" core.py
warnings.warn("Warning: converting a masked element to nan.", stacklevel=2)There was a problem hiding this comment.
The warning definitely comes from numpy. It is converting the floats for zmin/zmax float(np.ma.masked)
Ahh, now I see that (maybe unfortunately?) the levels actually have values now, so we only have the two warnings (there used to be other level related warnings on earlier versions):
[-1.0e-13 -7.5e-14 -5.0e-14 -2.5e-14 0.0e+00 2.5e-14 5.0e-14 7.5e-14 1.0e-13]
I guess these warnings don't really help much for the root of the problem, so I'd actually suggest getting rid of them altogether by converting the typecasts to: z.min().astype(float), and think about instead giving a more helpful error message somewhere else.
There was a problem hiding this comment.
So, should we close this PR and add z.min().astype(float) & z.max().astype(float) to a new one?
I'm getting the correct result using astype
There was a problem hiding this comment.
That seems like a reasonable fix to me and seems to line up with the plt.plot([np.nan], [np.nan]) case not issuing any warnings either.
PR Summary
This PR adds checks/tests for the all NANs test in
plt.contouras mentioned in issue #14124.Closes #14124.
PR Checklist
Documentation and Tests
pytestpasses)