Skip to content

Disable discarded animation warning on save #25339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 2, 2023
Merged

Disable discarded animation warning on save #25339

merged 1 commit into from
Mar 2, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 28, 2023

PR Summary

This tests is checking that the animation raises a reasonable error if it cannot be saved to a directory. But that triggers the warning that the animation was not saved.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added this to the v3.7.1 milestone Feb 28, 2023
timhoffm
timhoffm approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid quick-fix. Though @anntzer's suggestion seems slightly better.

@QuLogic QuLogic force-pushed the test-anim-warning branch from 4e7052d to 3b682de Compare March 2, 2023 08:21
@QuLogic QuLogic changed the title TST: Avoid warning about discarded Animation Disable discarded animation warning on save Mar 2, 2023
@QuLogic QuLogic requested a review from timhoffm March 2, 2023 08:22
@QuLogic QuLogic force-pushed the test-anim-warning branch from 3b682de to f2bcaef Compare March 2, 2023 08:28
@tacaswell tacaswell merged commit f1bed13 into matplotlib:main Mar 2, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 2, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 2, 2023
@tacaswell @meeseeksmachine
Backport PR matplotlib#25339: Disable discarded animation warning on …
d526148 
…save
QuLogic added a commit that referenced this pull request Mar 2, 2023
@QuLogic
Merge pull request #25368 from meeseeksmachine/auto-backport-of-pr-25…
925e1e5 
…339-on-v3.7.x

Backport PR #25339 on branch v3.7.x (Disable discarded animation warning on save)
@QuLogic QuLogic deleted the test-anim-warning branch March 20, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm Awaiting requested review from timhoffm

Assignees
No one assigned
Labels
topic: animation topic: testing
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @tacaswell @anntzer @timhoffm