-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Bump minimum QT5 version to 5.12 #25363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1479b18
to
0009b81
Compare
fcd9d39
to
356a497
Compare
👍 in principle (5.12 in from 2019). |
For pyside2 there are no wheel on pypi for Python 3.11, but there are conda packages. That is the thing messing about right now. I guess it is not that hard to fix, but seems a bit annoying that pyside2/py3.11 is the only combination not working... |
4aa885b
to
5c753cc
Compare
we use a full conda stack on appeveyor so we could test pyside2 + py311 there. |
Seem like the following versions of pyside2 are used on GA (for Linux) 3.9 minimum
3.9 and 3.10
3.11
Not so obvious why... Note that 3.11 is using a version for 3.5-3.7. The |
More recent versions of pyside2 have an explicit pyside6 is available for py 3.11, though |
< insert note about the importance of being able to adjust pins post-build and the ground truth of the dependencies living outside of the build artifact > |
The outstanding question here is which versions of which bindings we are testing so we are sure that what we are claiming in the minimum actually works. |
This is from the minver test section: matplotlib/.github/workflows/tests.yml Lines 56 to 59 in 85eadb3
So I guess that it is far to say that we test with 5.12 if nothing else (although for pyside2 we actually cannot). |
I have rebased this. As noted, we already test with 5.12 as the minimum version. |
This is a follow-up to #24919 where the version was bumped in the CI, but any effects were ignored. |
PR Summary
Primarily to open the discussion and see if it passes for all QT versions on the CI.
As far as I can tell, 5.12 is the lowest version where there are wheels for Python 3.9. (conda-forge has 5.12.3 as the next after 5.9.2.)
One should maybe get rid of the
_to_int
-stuff as well, but I did not really follow everything with the bit-manipulation there.PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst