BLD: Pre-download Qhull license to put in wheels #25364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a12eaf3 to
184460f
Compare
We couldn't work out what exactly changed to stop the license being included, so work around that by pre-downloading it. Fixes matplotlib#25212
tacaswell
approved these changes
Mar 2, 2023
|
Results are: |
ksunden
approved these changes
Mar 3, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 3, 2023
oscargus
added a commit
that referenced
this pull request
Mar 3, 2023
…364-on-v3.7.x Backport PR #25364 on branch v3.7.x (BLD: Pre-download Qhull license to put in wheels)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We couldn't work out what exactly changed to stop the license being included, so work around that by pre-downloading it.
Fixes #25212
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst