Skip to content

TST: unbreak appveyor #25435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2023
Merged

TST: unbreak appveyor #25435

merged 1 commit into from
Mar 12, 2023

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Mar 11, 2023

PR Summary

Resolves #25416. I just followed the instructions in the test docstring

matplotlib/lib/matplotlib/tests/test_doc.py

Lines 6 to 10 in bacd025

We have copied EXAMPLE_HEADER and modified it to include meta keywords.
This test monitors that the version we have copied is still the same as
the EXAMPLE_HEADER in sphinx-gallery. If sphinx-gallery changes its
EXAMPLE_HEADER, this test will start to fail. In that case, please update
the monkey-patching of EXAMPLE_HEADER in conf.py.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@rcomer rcomer added this to the v3.7.2 milestone Mar 11, 2023
@rcomer rcomer added the CI: testing CI configuration and testing label Mar 11, 2023
@oscargus oscargus merged commit f852726 into matplotlib:main Mar 12, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 12, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 12, 2023
@oscargus @meeseeksmachine
Backport PR matplotlib#25435: TST: unbreak appveyor
25089da
rcomer added a commit that referenced this pull request Mar 12, 2023
@rcomer
Merge pull request #25437 from meeseeksmachine/auto-backport-of-pr-25…
0373bf4 
…435-on-v3.7.x

Backport PR #25435 on branch v3.7.x (TST: unbreak appveyor)
@rcomer rcomer deleted the unbreak-appveyor branch March 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.7.2
Development

Successfully merging this pull request may close these issues.

Sphinx-Gallery 0.12 kills AppVeyor tests
3 participants
@rcomer @greglucas @oscargus