-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: Suggest replacement for tostring_rgb #25502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this makes sense! |
I am 👍🏻 on this and adding the note to the message itself as well. |
Note that it was also suggested to deprecate tostring_argb (#25484 (review)). In the use case of mne-python (mne-tools/mne-python#11574?) I would suggest using e.g. |
It seems like this should be the suggested replacement then, right? |
It's not really a direct replacement, as the channel order is not the same; it depends on what exactly you want (but in the case of MNE python you're really just checking that the values are the same, so the channel order doesn't matter). Also this doesn't do the conversion-to-a-string that in MNE-python's case gets immediately undone by np.frombuffer. |
Okay pushed an updated version! |
Since you're touching this file, can you also rename it to |
@QuLogic done! |
We hit this
DeprecationWarning
in MNE-Python (EDIT: After 9c79686) and I had to go to the commits to see the comment thatargb
should cover most use cases.If this makes sense to add then I'll modify the actual warning itself, too, which would have made finding the workaround even faster.