-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Delete annotate_simple_coord02.py #25533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Redundant examples file deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
@@ -10,3 +10,4 @@ pillow==8.0.0 | |||
pyparsing==2.3.1 | |||
python-dateutil==2.7 | |||
fonttools==4.22.0 | |||
pytest==3.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears you have accidentally included your possible change for #23154 here. Please put that in a separate PR. Note that it is best to use a branch other than main
in order to avoid conflating PRs like this.
https://matplotlib.org/devdocs/devel/development_workflow.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I should put the pull request in a separate branch in the original scipy repo itself right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And should I create a new branch in scipy or should I do it on an existing branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshvardhan2707 we have some guidance on working with branches here:
https://matplotlib.org/devdocs/devel/development_workflow.html
I’m going to close this one as it has stalled for a while. @harshvardhan2707 if you are still interested in working on this I suggest you create a new branch and make a new pull request from that. If you need help, feel free to ask questions in our incubator gitter room. |
Fixes #24723
Removed
annotate_simple_coord02.py
file.Redundant examples deleted