Skip to content

Delete annotate_simple_coord02.py #25533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+1 −22
Closed

Delete annotate_simple_coord02.py #25533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25bde34
Delete annotate_simple_coord02.py
harshvardhan2707 Mar 22, 2023
855a6ed
Update minver.txt
harshvardhan2707 Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions galleries/examples/userdemo/annotate_simple_coord02.py
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions requirements/testing/minver.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ pillow==8.0.0
pyparsing==2.3.1
python-dateutil==2.7
fonttools==4.22.0
pytest==3.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears you have accidentally included your possible change for #23154 here. Please put that in a separate PR. Note that it is best to use a branch other than main in order to avoid conflating PRs like this.
https://matplotlib.org/devdocs/devel/development_workflow.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I should put the pull request in a separate branch in the original scipy repo itself right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should I create a new branch in scipy or should I do it on an existing branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshvardhan2707 we have some guidance on working with branches here:
https://matplotlib.org/devdocs/devel/development_workflow.html