Use raw instead of png for font manager memory leak test #25569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of Pillow (notably v9.2.0 is what I had installed) trigger a failure on this test that looks the same as if it was a failure on our own part. v9.4.0 of Pillow does not have the same behavior, hence CI does not catch it. This changes to svg to avoid the external dependency triggering the failure. The fontmanager lookup that we are explicitly trying to test here does still trigger for svg output, but the pillow generated one does not
|
Would it be safer to output with |
|
I agree raw would be better here. Would still run it through Agg (which I am 95% sure is faster) rather than the svg backend (which does oodles of text formatting). |
tacaswell
reviewed
Mar 30, 2023
tacaswell
approved these changes
Mar 30, 2023
QuLogic
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some versions of Pillow (notably v9.2.0 is what I had installed) trigger a
failure on this test that looks the same as if it was a failure on our own part.
v9.4.0 of Pillow does not have the same behavior, hence CI does not catch it.
This changes to svg to avoid the external dependency triggering the failure.
The fontmanager lookup that we are explicitly trying to test here does still
trigger for svg output, but the pillow generated one does not
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst