Splitting navigation and toolbar #2557
Closed
+455
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to the request to split #2465 into several smaller PRs.
Goals
Main Goal
Separate the navigation state from the GUI (or physical) toolbar. Without touching any base class (as much as possible), to avoid forced refactor of other backends.
Secondary Goal
Add reconfiguration capabilities to the toolbar
Implementation
The following base classes were added
Includes Gtk3 implementation
Future
If the functionality is worth the effort, and all the backends are ported to use this classes, it will be possible to merge NavigationBase and NavigationToolbar2.
Note
This is very similar to the idea of #1849 different implementation without touching the bases classes.