Expire remaining 3.6 deprecations #25584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Mar 31, 2023
QuLogic
approved these changes
Apr 5, 2023
rcomer
reviewed
Apr 9, 2023
rcomer
approved these changes
Apr 11, 2023
|
Are the test failures understood? They are the same for py3.9 and py3.10, though I can't see how they'd relate to this change. |
|
They look like #25658. |
pending deprecations remain in axis3D and in Figure
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
QuLogic
reviewed
Apr 17, 2023
QuLogic
reviewed
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I believe the only
3.6deprecations that remain are still marked as "pending", those include some in axis3d and some in Figure.The expiration for
Colorbarfilled kwarg is rather minimal.It was originally deprecated in #21933, @jklymak do you think more clean up is needed?
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst