Skip to content

DOC: fix Sphinx Gallery discussion to explain mixed subddirs #25618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Apr 4, 2023

PR Summary

Update the "Writing documentation" for the changes from #25395 to point out the possibility of galleries with *.py and *.rst files in them (with links to the SG documentation about this).

Also added a table of galleries with their sources and where they end up in the build.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@jklymak jklymak marked this pull request as draft April 5, 2023 04:26
@jklymak
Copy link
Member Author

jklymak commented Apr 5, 2023

@jklymak jklymak force-pushed the doc-describe-mixed-sg branch 3 times, most recently from 8994247 to 0539533 Compare April 5, 2023 21:09
@jklymak jklymak marked this pull request as ready for review April 5, 2023 22:08
The first three are traditional galleries, :file:`galleries/users_explain` is a
mixed gallery where some of the files are raw ``*.rst`` files rather than
``*.py`` files; Sphinx Gallery just copies those from the location to the build
location (see :ref:`raw_restructured_gallery`, below). To exclude an example
from having an plot generated insert "sgskip" somewhere in the filename.
Copy link
Member

@melissawm melissawm Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a sentence part missing here? sorry my english has failed me here 😄 but I guess we should have "from having a plot generated"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's correct English, but I agree it's not very easy to parse. I'll take another swing at it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, modified to be a little more clear (I hope)

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a rebase to fix CircleCI.

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@jklymak jklymak force-pushed the doc-describe-mixed-sg branch from 0879780 to d92ab0b Compare April 15, 2023 15:20
@jklymak jklymak added this to the v3.8.0 milestone Apr 17, 2023
@QuLogic QuLogic merged commit 4aa5ac7 into matplotlib:main Apr 17, 2023
@jklymak jklymak deleted the doc-describe-mixed-sg branch April 17, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants