Skip to content

TST: Import MatplotlibDeprecationWarning consistently #25690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2023
Merged

TST: Import MatplotlibDeprecationWarning consistently #25690

merged 1 commit into from
Apr 15, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 15, 2023

PR Summary

Just a minor thing I noticed in https://github.com/matplotlib/matplotlib/pull/25651/files/fe0b069b06e3ee98108a20b30d9c1f10915ee77d#diff-fd4f809a4a2ca8b97875eff013bac232c55ca3f92f165117f778960ca1795869

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

QuLogic
QuLogic commented Apr 15, 2023
View reviewed changes
lib/matplotlib/tests/test_api.py
Comment on lines +6 to 7
import matplotlib as mpl
from matplotlib import _api
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly, these could remain with _api since this is test_api.py, but I chose to go for consistency.

rcomer
rcomer approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew I’d copied it from somewhere!

@oscargus oscargus merged commit cf9a887 into matplotlib:main Apr 15, 2023
@QuLogic QuLogic deleted the test-deprecations branch April 15, 2023 09:31
@oscargus oscargus added this to the v3.8.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus approved these changes

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @oscargus @rcomer